修改agent 缓存的lastUpdate 更新策略 #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
原来只在AgentVersion，IP, PluginVersion 变化时，才做缓存更新, 这样一个问题的是没有准确记录agent 的心跳时间，从而导致基于lastUpdate 的一些判断没有意义, 比如DeleteStaleAgents 或者基于lasteUpdate 实现的agent.alive 存活状态就无法实现
laiwei
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原来只在AgentVersion，IP, PluginVersion 变化时，才做缓存更新,
这样一个问题的是没有准确记录agent 的心跳时间，从而导致基于lastUpdate
的一些判断没有意义, 比如DeleteStaleAgents 或者基于lasteUpdate
实现的agent.alive 存活状态就无法实现